RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v15]

Prasanta Sadhukhan psadhukhan at openjdk.org
Fri Jun 2 08:12:55 UTC 2023


> Two CSS AttributeSet-s can be compared using the AttributeSet.isEqual() method which can fail due to missing implementation of equals method in CSS subclasses.
> In this issue, even when two CSS AttributeSet has same 42 font size string value, Object equality fails.
> Fixed by implementing the equality and hashCode method for CSS.FontSize class.
> 
> All jtreg/jck tests are ok

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Optimization removed to use local variables for non-percentage units

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13405/files
  - new: https://git.openjdk.org/jdk/pull/13405/files/833ff8fd..4683844d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13405&range=14
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13405&range=13-14

  Stats: 8 lines in 1 file changed: 6 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/13405.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13405/head:pull/13405

PR: https://git.openjdk.org/jdk/pull/13405



More information about the client-libs-dev mailing list