RFR: 8307934 JRobot.moveMouseTo must access component on EDT

Phil Race prr at openjdk.org
Wed Jun 7 17:56:44 UTC 2023


On Wed, 7 Jun 2023 12:54:54 GMT, Renjith Kannath Pariyangad <duke at openjdk.org> wrote:

> Hi Reviewers,
> 
> I have updated the JRobot.java file for enabling EDT support, along with I have removed warning BUTTON1_MASK with 'BUTTON1_DOWN_MASK'.
> 
> Regards,
> Renjith

test/jdk/javax/swing/regtesthelpers/JRobot.java line 260:

> 258:      */
> 259:     public void convertRectToScreen(Rectangle r, Component c) {
> 260:         AtomicReference<Point> p = new AtomicReference<>();

So this change must be documented on all affected entry points, so that people understand
what it does.
Also touching Robot means you need to run ALL tests that use this utility and make sure you didn't break any. 
Have you done that ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14354#discussion_r1221975000



More information about the client-libs-dev mailing list