RFR: 8307934 JRobot.moveMouseTo must access component on EDT

Renjith Kannath Pariyangad duke at openjdk.org
Thu Jun 8 03:23:47 UTC 2023


On Wed, 7 Jun 2023 17:54:18 GMT, Phil Race <prr at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> I have updated the JRobot.java file for enabling EDT support, along with I have removed warning BUTTON1_MASK with 'BUTTON1_DOWN_MASK'.
>> 
>> Regards,
>> Renjith
>
> test/jdk/javax/swing/regtesthelpers/JRobot.java line 260:
> 
>> 258:      */
>> 259:     public void convertRectToScreen(Rectangle r, Component c) {
>> 260:         AtomicReference<Point> p = new AtomicReference<>();
> 
> So this change must be documented on all affected entry points, so that people understand
> what it does.
> Also touching Robot means you need to run ALL tests that use this utility and make sure you didn't break any. 
> Have you done that ?

Thanks @prrace for the reviews, 
I have added EDT support for 'getCenterPoint' and 'convertRectToScreen' functions, executed all the tests which are using this function and confirmed its working.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14354#discussion_r1222406811



More information about the client-libs-dev mailing list