RFR: 8306871: Open source more AWT Drag & Drop tests

Andrey Turbanov aturbanov at openjdk.org
Tue May 2 16:13:21 UTC 2023


On Fri, 28 Apr 2023 18:34:36 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> This PR open sources more AWT DnD & Event related tests

test/jdk/java/awt/event/InputEvent/MouseModsTest.java line 145:

> 143: 
> 144:     static int getKeycode(int ctrl) {
> 145:         switch(ctrl) {

Suggestion:

        switch (ctrl) {

test/jdk/java/awt/event/InputEvent/MouseModsTest.java line 154:

> 152: 
> 153:     static int getKeyModifier(int ctrl) {
> 154:         switch(ctrl) {

Suggestion:

        switch (ctrl) {

test/jdk/java/awt/event/InputEvent/MouseModsTest.java line 163:

> 161: 
> 162:     static int getMouseModifier(int btn) {
> 163:         switch(btn) {

Suggestion:

        switch (btn) {

test/jdk/java/awt/event/KeyEvent/AltGraphModifier.java line 83:

> 81:                             if (modifierPress[i] == true) {
> 82:                                 if ((kp.getModifiersEx() & inputMasks[i]) == inputMasks[i]) {
> 83:                                 }  else {

Suggestion:

                                } else {

test/jdk/java/awt/event/KeyEvent/KeyTyped/CancelKeyTyped.java line 114:

> 112: 
> 113:             protected void printKey(KeyEvent evt) {
> 114:                 switch(evt.getID()) {

Suggestion:

                switch (evt.getID()) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13725#discussion_r1182760866
PR Review Comment: https://git.openjdk.org/jdk/pull/13725#discussion_r1182761072
PR Review Comment: https://git.openjdk.org/jdk/pull/13725#discussion_r1182761201
PR Review Comment: https://git.openjdk.org/jdk/pull/13725#discussion_r1182760384
PR Review Comment: https://git.openjdk.org/jdk/pull/13725#discussion_r1182759973



More information about the client-libs-dev mailing list