RFR: 8306871: Open source more AWT Drag & Drop tests [v2]

[Damon Nguyen]

On Tue, 2 May 2023 16:10:16 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix syntax. Edit comment
>
> test/jdk/java/awt/event/InputEvent/MouseModsTest.java line 145:
> 
>> 143: 
>> 144:     static int getKeycode(int ctrl) {
>> 145:         switch(ctrl) {
> 
> Suggestion:
> 
>         switch (ctrl) {

Fixed

> test/jdk/java/awt/event/InputEvent/MouseModsTest.java line 154:
> 
>> 152: 
>> 153:     static int getKeyModifier(int ctrl) {
>> 154:         switch(ctrl) {
> 
> Suggestion:
> 
>         switch (ctrl) {

Fixed

> test/jdk/java/awt/event/InputEvent/MouseModsTest.java line 163:
> 
>> 161: 
>> 162:     static int getMouseModifier(int btn) {
>> 163:         switch(btn) {
> 
> Suggestion:
> 
>         switch (btn) {

Fixed

> test/jdk/java/awt/event/KeyEvent/AltGraphModifier.java line 83:
> 
>> 81:                             if (modifierPress[i] == true) {
>> 82:                                 if ((kp.getModifiersEx() & inputMasks[i]) == inputMasks[i]) {
>> 83:                                 }  else {
> 
> Suggestion:
> 
>                                 } else {

Fixed

> test/jdk/java/awt/event/KeyEvent/KeyTyped/CancelKeyTyped.java line 114:
> 
>> 112: 
>> 113:             protected void printKey(KeyEvent evt) {
>> 114:                 switch(evt.getID()) {
> 
> Suggestion:
> 
>                 switch (evt.getID()) {

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13725#discussion_r1183893293
PR Review Comment: https://git.openjdk.org/jdk/pull/13725#discussion_r1183893416
PR Review Comment: https://git.openjdk.org/jdk/pull/13725#discussion_r1183893511
PR Review Comment: https://git.openjdk.org/jdk/pull/13725#discussion_r1183893216
PR Review Comment: https://git.openjdk.org/jdk/pull/13725#discussion_r1183893133