RFR: 8306489: Open source AWT List related tests

Sergey Bylokhov serb at openjdk.org
Tue May 2 20:04:18 UTC 2023


On Tue, 2 May 2023 06:26:36 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> This PR is to open source List related AWT tests.

test/jdk/java/awt/List/ISCAfterRemoveAllTest.java line 140:

> 138:         System.out.println(ie);
> 139:         // We shouldn't generate any events since the list is empty
> 140:         passed = false;

you set this flag on EDT and then read on the main thread, some sync is needed.

test/jdk/java/awt/List/ListEnterExitTest.java line 105:

> 103: 
> 104:     public void mouseEntered(MouseEvent e) {
> 105:         passed = true;

Can we check enter and exit events separately by different flags? The access to "passed" should use some synchronisation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13748#discussion_r1182993106
PR Review Comment: https://git.openjdk.org/jdk/pull/13748#discussion_r1182995680



More information about the client-libs-dev mailing list