RFR: 8306489: Open source AWT List related tests [v2]
Abhishek Kumar
abhiscxk at openjdk.org
Wed May 3 07:01:31 UTC 2023
On Tue, 2 May 2023 19:57:03 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comment update
>
> test/jdk/java/awt/List/ISCAfterRemoveAllTest.java line 140:
>
>> 138: System.out.println(ie);
>> 139: // We shouldn't generate any events since the list is empty
>> 140: passed = false;
>
> you set this flag on EDT and then read on the main thread, some sync is needed.
Updated.
> test/jdk/java/awt/List/ListEnterExitTest.java line 105:
>
>> 103:
>> 104: public void mouseEntered(MouseEvent e) {
>> 105: passed = true;
>
> Can we check enter and exit events separately by different flags? The access to "passed" should use some synchronisation.
Added separate flags to test enter and exit events.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13748#discussion_r1183301492
PR Review Comment: https://git.openjdk.org/jdk/pull/13748#discussion_r1183301860
More information about the client-libs-dev
mailing list