RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v2]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Wed May 3 03:48:22 UTC 2023
On Tue, 2 May 2023 18:16:34 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - Test fix
>> - Test fix
>> - Review comment address
>
> test/jdk/javax/swing/text/html/CSS/CSSAttributeEqualityBug.java line 44:
>
>> 42:
>> 43: private static void testFontSize() {
>> 44: StyleSheet ss = new StyleSheet();
>
> The `StyleSheet` object isn't used in any of the tests, you can safely remove it.
it is being used
`ss.addCSSAttribute(a, CSS.Attribute.FONT_SIZE, fontSize);`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13405#discussion_r1183214010
More information about the client-libs-dev
mailing list