RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v2]

Alexey Ivanov aivanov at openjdk.org
Thu May 4 12:42:18 UTC 2023


On Wed, 3 May 2023 03:43:09 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> test/jdk/javax/swing/text/html/CSS/CSSAttributeEqualityBug.java line 44:
>> 
>>> 42: 
>>> 43:     private static void testFontSize() {
>>> 44:         StyleSheet ss = new StyleSheet();
>> 
>> The `StyleSheet` object isn't used in any of the tests, you can safely remove it.
>
> it is being used
> `ss.addCSSAttribute(a, CSS.Attribute.FONT_SIZE, fontSize);`

My bad! I lost track of it, and it appeared unused to me; I should've pulled the changes into a local branch and opened the test in IDE.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13405#discussion_r1184957195



More information about the client-libs-dev mailing list