RFR: 8306638: Open source some AWT tests related to datatransfer and Toolkit

Damon Nguyen dnguyen at openjdk.org
Fri May 12 16:39:56 UTC 2023


On Tue, 25 Apr 2023 13:48:16 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

> This PR open sources some tests related to AWT datatransfer and Toolkit.

test/jdk/java/awt/Toolkit/ToolkitListenerTest/ToolkitListenerTest.java line 64:

> 62:         EventQueue.invokeAndWait(() -> {
> 63:             frame = new Frame("ToolkitListenerTest");
> 64:             frame.setSize(200,200);

Add a space after comma

test/jdk/java/awt/datatransfer/DataFlavor/BestTextFlavorTest/BestTextFlavorTest.java line 67:

> 65:             System.out.println("ClassNotFound Exception is thrown when"+
> 66:                 "flavors are created");
> 67:         }//catch

We've been typically removing these comments at the end-brackets

test/jdk/java/awt/datatransfer/DataFlavor/BestTextFlavorTest/BestTextFlavorTest.java line 85:

> 83:         if(bestFlavor2.match(bestFlavor1)) {
> 84:             System.out.println("The test is Passed");
> 85:             System.out.println("Pass");

Redundant prints

test/jdk/java/awt/datatransfer/FileTransferAWTLockTest/FileTransferAWTLockTest.java line 48:

> 46:         if (!(System.getProperty("os.name").startsWith("Linux"))) {
> 47:             return;
> 48:         }

Isn't this already covered by the @requires?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13642#discussion_r1192583347
PR Review Comment: https://git.openjdk.org/jdk/pull/13642#discussion_r1192588172
PR Review Comment: https://git.openjdk.org/jdk/pull/13642#discussion_r1192588655
PR Review Comment: https://git.openjdk.org/jdk/pull/13642#discussion_r1192589278



More information about the client-libs-dev mailing list