RFR: 8289547 : Update javax/swing/Popup/TaskbarPositionTest.java [v2]

Renjith Kannath Pariyangad duke at openjdk.org
Mon May 15 04:17:48 UTC 2023


On Fri, 12 May 2023 18:32:29 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated test description, disabling all system shortcut is required to run the test case on MAC
>
> test/jdk/javax/swing/Popup/TaskbarPositionTest.java line 64:
> 
>> 62:  * @summary Tests the location of the heavy weight popup portion of JComboBox,
>> 63:  * JMenu and JPopupMenu.
>> 64:  * On MAC disable all system shortcuts before executing this test case.
> 
> Well, the test uses only one particular shortcut which was introduced in macOS Ventura.
> I'd rather have a more specific statement, something like this: The test uses Ctrl+Down Arrow (↓) which is a system shortcut on macOS, disable it in system settings, otherwise the test will fail.
> 
> The systems which are exclusively used for running tests should have all system shortcuts disabled. It may be *unfeasible* to disable all the shortcuts on a system that you use regularly for doing your work as well as for running tests (while you're updating it or fixing a bug).

Thanks @aivanov-jdk, that make more sense and I have updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13578#discussion_r1193307899



More information about the client-libs-dev mailing list