RFR: 8318023: Implement IPP output-bin attribute extension on macOS [v2]

Phil Race prr at openjdk.org
Thu Nov 2 21:54:01 UTC 2023


On Wed, 18 Oct 2023 17:14:06 GMT, Alexander Scherbatiy <alexsch at openjdk.org> wrote:

> > Why did you file a new RFE when you know about the existing one ? Close your new one as a dup. and redirect everything to the existing one. Also I don't see any UI work to enhance the dialog so it can be selected. And why restrict it to macOS ? Is it an issue of testing ?
> 
> My idea was to use JDK-8314070 as an umbrella and provide fixes for macOS, Linux, and Windows separately. While the OutputBin public API is not fixed any change in it would require to re-test the fix on all 3 platforms. The fix for the UI dialog requires an additional test with a printer dialog so there would be 2 tests for each platform for re-testing for each essential change in the fix.

I'm struggling to follow the logic.
This change clearly contains the public API which is the first thing you need.
Burying it in the fix for one platform that happens to be the first one you coded isn't right.

If you really want to stagger it then proceed as follows
1) Add just the new API class under the existing RFE
2) Add  this macOS support for it under this ID
3) Add the Swing dialog UI support for selecting the bin - easier once you have one implementation
4) Add Linux support (CUPS, so should be similar to macOS)
5) Add Windows support, but SFAIK GDI has no support for this, so likely impossible to do.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16166#issuecomment-1791587457


More information about the client-libs-dev mailing list