RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v2]

[Julian Waters]

On Thu, 2 Nov 2023 18:46:15 GMT, Phil Race <prr at openjdk.org> wrote:

>> I can try doing that, yes. There was actually a commit before this one that addressed the same issue in awt, but it missed this one since without -permissive- this error isn't caught, see [8241087](https://bugs.openjdk.org/browse/JDK-8241087)
>> 
>> Looking at the error logs, I believe this may be due to an issue this causes with templates in the comip.h header, but I don't think that's the main problem to be worried about, rather it's that malloc (and calloc and realloc and the JDK's ExceptionOccured method too by the way) is redefined like this in the first place. I don't have any ideas for how to deal with that at the moment unfortunately
>
> this is very worrying as it seems to suggest that in the same C++ source file we have  some code that wants the standard malloc, some that wants a redefined malloc, and 
> I've no idea of the consequences.

To my knowledge this has been an issue before, and was fixed by [8241087](https://bugs.openjdk.org/browse/JDK-8241087), but it missed this one. The code that needs the malloc is in a template in Microsoft's headers, which I don't think we can change. I'm not sure what other solution we can come up with for this

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1381111882