RFR: 8319598: SMFParser misinterprets interrupted running status
Sergey Bylokhov
serb at openjdk.org
Fri Nov 10 21:10:58 UTC 2023
On Tue, 7 Nov 2023 19:18:28 GMT, Jan Trukenmüller <duke at openjdk.org> wrote:
> The MIDI file parser misinterprets events without status byte when they appear directly after a Meta of SysEx event.
>
> For my bugfix I had to decide between two possible solutions:
> - Strict solution: Throw an InvalidMidiDataException
> - Tolerant solution: Use the status of the last channel event as running status
>
> I used the tolerant solution.
> I will send an email to the list client-libs-dev with my reasons.
test/jdk/javax/sound/midi/File/SMFInterruptedRunningStatus.java line 70:
> 68: }
> 69: }
> 70:
please split the long lines above to have 80 chars per line.
The code below for "SMF_1"/etc are fine as is.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16546#discussion_r1389923729
More information about the client-libs-dev
mailing list