RFR: 8319598: SMFParser misinterprets interrupted running status [v2]

Jan Trukenmüller duke at openjdk.org
Sat Nov 11 12:32:16 UTC 2023


On Fri, 10 Nov 2023 21:08:27 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Jan Trukenmüller has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   reduced line lengths
>
> test/jdk/javax/sound/midi/File/SMFInterruptedRunningStatus.java line 70:
> 
>> 68:         }
>> 69:     }
>> 70: 
> 
> please split the long lines above to have 80 chars per line.
> 
> The code below for "SMF_1"/etc are fine as is.

Thank you for the suggestion. I reduced the line lengths.
Also for the code below SMF_..., even if you think it was fine.
I think now it's even more readable. But I can redo this part, if you think it was better before.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16546#discussion_r1390218225


More information about the client-libs-dev mailing list