RFR: 8319598: SMFParser misinterprets interrupted running status [v2]

Jan Trukenmüller duke at openjdk.org
Sat Nov 11 12:32:15 UTC 2023


> The MIDI file parser misinterprets events without status byte when they appear directly after a Meta of SysEx event.
> 
> For my bugfix I had to decide between two possible solutions:
> - Strict solution: Throw an InvalidMidiDataException
> - Tolerant solution: Use the status of the last channel event as running status
> 
> I used the tolerant solution.
> I will send an email to the list client-libs-dev with my reasons.

Jan Trukenmüller has updated the pull request incrementally with one additional commit since the last revision:

  reduced line lengths

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/16546/files
  - new: https://git.openjdk.org/jdk/pull/16546/files/2c23d725..d7aea29a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16546&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16546&range=00-01

  Stats: 69 lines in 1 file changed: 33 ins; 0 del; 36 mod
  Patch: https://git.openjdk.org/jdk/pull/16546.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16546/head:pull/16546

PR: https://git.openjdk.org/jdk/pull/16546


More information about the client-libs-dev mailing list