RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v28]
Phil Race
prr at openjdk.org
Fri Nov 17 18:50:57 UTC 2023
On Fri, 17 Nov 2023 08:24:18 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.
>
> Julian Waters has updated the pull request incrementally with two additional commits since the last revision:
>
> - Includes for awt_Component.cpp
> - Likewise for awt_Component.cpp
src/java.desktop/windows/native/libawt/windows/awt_Canvas.cpp line 217:
> 215: env->ExceptionClear();
> 216: JNU_ThrowNullPointerException(env, "peer");
> 217: env->DeleteGlobalRef(canvas);
you didn't code this up the way I did in my comment, which I think you should have done, and here you are deleting a ref to NULL, and the string passed to throw doesn't mention the canvas, which it can do unlike the old code.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1397737624
More information about the client-libs-dev
mailing list