RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v28]

[Julian Waters]

On Fri, 17 Nov 2023 18:47:56 GMT, Phil Race <prr at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Includes for awt_Component.cpp
>>  - Likewise for awt_Component.cpp
>
> src/java.desktop/windows/native/libawt/windows/awt_Canvas.cpp line 217:
> 
>> 215:         env->ExceptionClear();
>> 216:         JNU_ThrowNullPointerException(env, "peer");
>> 217:         env->DeleteGlobalRef(canvas);
> 
> you didn't code this up the way I did in my comment, which I think you should have done, and here you are deleting a ref to NULL, and the string passed to throw doesn't mention the canvas, which it can do unlike the old code.

Sorry, I was trying to keep as close to the original code as possible. Woah, does that mean the original was bugged, since it was deleting a NULL canvas? Anyway, should I change the string to canvas or just keep it as "peer" like the original code does in that case?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1398213842