RFR: 8224261: JProgressBar always with border painted around it [v2]
Abhishek Kumar
abhiscxk at openjdk.org
Mon Nov 20 05:28:53 UTC 2023
On Fri, 17 Nov 2023 23:04:53 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comment fix
>
> test/jdk/javax/swing/JProgressBar/TestProgressBarBorder.java line 70:
>
>> 68: isImgSame = Util.compareBufferedImages(borderPaintedImg, borderNotPaintedImg);
>> 69:
>> 70: if (isImgSame) {
>
> Maybe worth renaming `isImgSame` to something that reads slightly smoother like `isImgEqual`, `isEqual`, or `isMatching`. Could just even inser the `Util.compareBufferedImages()` into the if statement for the failure check if you prefer. But I like the variable for better readability.
Updated to `isImgEqual`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16467#discussion_r1398676201
More information about the client-libs-dev
mailing list