RFR: 8224261: JProgressBar always with border painted around it [v6]
Abhishek Kumar
abhiscxk at openjdk.org
Wed Nov 22 04:25:39 UTC 2023
On Tue, 21 Nov 2023 19:34:19 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove line break
>
> test/jdk/javax/swing/JProgressBar/TestProgressBarBorder.java line 75:
>
>> 73: ImageIO.write(withBorder, "png", new File("withBorder.png"));
>> 74: ImageIO.write(withoutBorder, "png", new File("withoutBorder.png"));
>> 75: } catch (IOException e) {}
>
> Suggestion:
>
> } catch (IOException ignored) {}
>
> Naming the exception parameter `ignored` lets IDE know the exception is ignored, which removes the warning about *ignoring the exception*.
>
> (I used the name `ignored` in the snippet I pasted specifically for this reason.)
I missed somehow in previous commit. Updated now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16467#discussion_r1401486396
More information about the client-libs-dev
mailing list