RFR: 5108458: JTable does not properly layout its content [v6]

Tejesh R tr at openjdk.org
Wed Nov 22 07:00:10 UTC 2023


On Tue, 21 Nov 2023 14:41:07 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review fix
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTableUI.java line 2100:
> 
>> 2098:             for (int row = rMin; row <= rMax; row++) {
>> 2099:                 cellRect = table.getCellRect(row, cMax, false);
>> 2100:                 cellRect.x = SwingUtilities2.getXPosInRightToLeft(table, cMax);
> 
> Here, I have the same question: _Does it mean that `table.getCellRect` returns an incorrect value in right-to-left case?_

Yes, meaning it doesn't consider the offset to which table has to moved towards right in _right-to-left case_, especially when `Panel `size is more than the fixed `table ` size.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16374#discussion_r1401588886


More information about the client-libs-dev mailing list