RFR: 5108458: JTable does not properly layout its content [v6]
Tejesh R
tr at openjdk.org
Wed Nov 22 07:07:11 UTC 2023
On Tue, 21 Nov 2023 14:52:28 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review fix
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTableUI.java line 2108:
>
>> 2106: paintCell(g, cellRect, row, column);
>> 2107: }
>> 2108: cellRect.x += columnWidth;
>
> This is weird… if we paint columns in right-to-left order, x should decrease.
Here, we are painting from left-to-right order by starting with last column. It is only a convention, I guess painting this way is more simple that to actually paint from `right-to-left`. Here for both the orientations, we are painting from left-to-right, only difference is how we pick the columns.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16374#discussion_r1401593563
More information about the client-libs-dev
mailing list