RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v8]

Damon Nguyen dnguyen at openjdk.org
Thu Oct 12 22:05:33 UTC 2023


On Thu, 12 Oct 2023 16:27:45 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove excess
>
> test/jdk/java/awt/dnd/RejectDragDropActionTest.java line 103:
> 
>> 101:                  !p.equals(endPoint) && !incorrectActionDetected;
>> 102:                  p.translate(sign(endPoint.x - p.x),
>> 103:                          sign(endPoint.y - p.y))) {
> 
> Suggestion:
> 
>                  p.translate(sign(endPoint.x - p.x),
>                              sign(endPoint.y - p.y))) {
> 
> I'm probably the only one who prefers aligning wrapped lines… Doesn't it look better?

I agree, it does look neater. Unfortunately, my IDE doesn't default this (which makes sense) so I have to remember to do this when applicable. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16018#discussion_r1357479781


More information about the client-libs-dev mailing list