RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v8]

Alexey Ivanov aivanov at openjdk.org
Fri Oct 13 15:04:18 UTC 2023


On Thu, 12 Oct 2023 22:01:22 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> test/jdk/java/awt/dnd/RejectDragDropActionTest.java line 103:
>> 
>>> 101:                  !p.equals(endPoint) && !incorrectActionDetected;
>>> 102:                  p.translate(sign(endPoint.x - p.x),
>>> 103:                          sign(endPoint.y - p.y))) {
>> 
>> Suggestion:
>> 
>>                  p.translate(sign(endPoint.x - p.x),
>>                              sign(endPoint.y - p.y))) {
>> 
>> I'm probably the only one who prefers aligning wrapped lines… Doesn't it look better?
>
> I agree, it does look neater. Unfortunately, my IDE doesn't default this (which makes sense) so I have to remember to do this when applicable. Thanks.

I configured IDE to do it by default. Yet it doesn't make sense in all the cases.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16018#discussion_r1358382948


More information about the client-libs-dev mailing list