RFR: 8305321: Remove unused exports in java.desktop [v3]
Daniel Jeliński
djelinski at openjdk.org
Fri Oct 13 07:05:17 UTC 2023
On Thu, 12 Oct 2023 10:00:15 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Keep in mind that on Linux libawt is split into libawt, libawt_headless and libawt_xawt, and the export/import dependencies are different.
>
> I totally understand this. However, Windows specific symbols:
>
> 9 8 000380A0 GDIWinSD_InitDC
> 10 9 000385F0 GDIWindowSurfaceData_GetComp
> 11 A 000386C0 GDIWindowSurfaceData_GetOps
> 12 B 000386D0 GDIWindowSurfaceData_GetOpsNoSetup
> 13 C 000386E0 GDIWindowSurfaceData_GetWindow
>
> and others are still exported from `awt.dll`, I believe these can be made private.
>
> Yet I agree we need to be careful not to hide something that's used from other libraries.
Good point. I only checked the Linux exports/imports, will check the Windows-specific exports now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13261#discussion_r1357845707
More information about the client-libs-dev
mailing list