RFR: 8305321: Remove unused exports in java.desktop [v3]

Daniel Jeliński djelinski at openjdk.org
Fri Oct 13 07:53:22 UTC 2023


On Fri, 13 Oct 2023 07:01:08 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> I totally understand this. However, Windows specific symbols:
>> 
>>            9    8 000380A0 GDIWinSD_InitDC
>>          10    9 000385F0 GDIWindowSurfaceData_GetComp
>>          11    A 000386C0 GDIWindowSurfaceData_GetOps
>>          12    B 000386D0 GDIWindowSurfaceData_GetOpsNoSetup
>>          13    C 000386E0 GDIWindowSurfaceData_GetWindow
>> 
>> and others are still exported from `awt.dll`, I believe these can be made private.
>> 
>> Yet I agree we need to be careful not to hide something that's used from other libraries.
>
> Good point. I only checked the Linux exports/imports, will check the Windows-specific exports now.

Wait a sec, these symbols are removed from the export list in this PR. Are you saying that you still see them?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13261#discussion_r1357891580


More information about the client-libs-dev mailing list