RFR: 8315834: Open source several Swing JSpinner related tests [v2]

Abhishek Kumar abhiscxk at openjdk.org
Thu Sep 14 09:10:43 UTC 2023


On Wed, 13 Sep 2023 09:10:18 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Open source these Swing JSpinner related tests:
>> 
>> javax/swing/JSpinner/4522737/bug4522737.java
>> javax/swing/JSpinner/4656590/bug4656590.java
>> javax/swing/JSpinner/4680204/bug4680204.java
>> javax/swing/JSpinner/4862257/bug4862257.java
>> javax/swing/JSpinner/5104421/bug5104421.java
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review fix

test/jdk/javax/swing/JSpinner/bug4656590.java line 110:

> 108:             System.out.println("Test Passed!");
> 109:         } finally {
> 110:             if (frame != null) {

I think there is a discussion going on to keep this `frame null check` also inside SwingUtilities. 

Are you going to update here as well?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15678#discussion_r1325634582


More information about the client-libs-dev mailing list