RFR: 8315834: Open source several Swing JSpinner related tests [v2]

Tejesh R tr at openjdk.org
Thu Sep 14 09:23:42 UTC 2023


On Thu, 14 Sep 2023 09:08:05 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review fix
>
> test/jdk/javax/swing/JSpinner/bug4656590.java line 110:
> 
>> 108:             System.out.println("Test Passed!");
>> 109:         } finally {
>> 110:             if (frame != null) {
> 
> I think there is a discussion going on to keep this `frame null check` also inside SwingUtilities. 
> 
> Are you going to update here as well?

Yes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15678#discussion_r1325655706


More information about the client-libs-dev mailing list