RFR: JDK-8315876 Open source several Swing CSS related tests

Andrey Turbanov aturbanov at openjdk.org
Mon Sep 18 11:47:42 UTC 2023


On Fri, 15 Sep 2023 19:35:15 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Following tests are open sourced as part of this PR.
> 
> 1. test/jdk/javax/swing/text/html/CSS/bug4174871.java
> 2. test/jdk/javax/swing/text/html/CSS/bug4174874.java
> 3. test/jdk/javax/swing/text/html/CSS/bug4284162.java
> 4. test/jdk/javax/swing/text/html/CSS/bug4764897.java
> 5. test/jdk/javax/swing/text/html/HTMLDocument/bug4209280.java

test/jdk/javax/swing/text/html/CSS/bug4174871.java line 89:

> 87:         while (!(v instanceof javax.swing.text.html.ParagraphView)) {
> 88:             int n = v.getViewCount();
> 89:             Shape sh = v.getChildAllocation(n - 1,  r);

Suggestion:

            Shape sh = v.getChildAllocation(n - 1, r);

test/jdk/javax/swing/text/html/CSS/bug4174874.java line 88:

> 86:         while (!(v instanceof javax.swing.text.html.ParagraphView)) {
> 87:             int n = v.getViewCount();
> 88:             Shape sh = v.getChildAllocation(n - 1,  r);

Suggestion:

            Shape sh = v.getChildAllocation(n - 1, r);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15769#discussion_r1328597822
PR Review Comment: https://git.openjdk.org/jdk/pull/15769#discussion_r1328598073


More information about the client-libs-dev mailing list