RFR: JDK-8315876 Open source several Swing CSS related tests [v4]

Alexey Ivanov aivanov at openjdk.org
Tue Sep 19 10:35:50 UTC 2023


On Tue, 19 Sep 2023 00:00:45 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

> Looks like a valid explanation as to why `x + width` is used.

This is why `cellWidth` is a bad name: it doesn't convey the meaning. Consider *renaming the variable* or adding a comment to clarify the meaning.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15769#discussion_r1329908473


More information about the client-libs-dev mailing list