RFR: JDK-8315876 Open source several Swing CSS related tests [v4]
Alexey Ivanov
aivanov at openjdk.org
Tue Sep 19 10:35:48 UTC 2023
On Tue, 19 Sep 2023 00:22:35 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> Following tests are open sourced as part of this PR.
>>
>> 1. test/jdk/javax/swing/text/html/CSS/bug4174871.java
>> 2. test/jdk/javax/swing/text/html/CSS/bug4174874.java
>> 3. test/jdk/javax/swing/text/html/CSS/bug4284162.java
>> 4. test/jdk/javax/swing/text/html/CSS/bug4764897.java
>> 5. test/jdk/javax/swing/text/html/HTMLDocument/bug4209280.java
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>
> review updates
Changes requested by aivanov (Reviewer).
test/jdk/javax/swing/text/html/HTMLDocument/bug4209280.java line 36:
> 34: public static void main(String[] args) throws Exception {
> 35: String html = "<html><bold>Foo</bold></html>";
> 36: new JLabel(html);
Suggestion:
// The following line should throw no exceptions
new JLabel(html);
This may clarify the intention of the reader skipped the summary.
-------------
PR Review: https://git.openjdk.org/jdk/pull/15769#pullrequestreview-1632932610
PR Review Comment: https://git.openjdk.org/jdk/pull/15769#discussion_r1329910569
More information about the client-libs-dev
mailing list