RFR: JDK-8315876 Open source several Swing CSS related tests [v4]

Harshitha Onkar honkar at openjdk.org
Tue Sep 19 17:02:57 UTC 2023


On Tue, 19 Sep 2023 10:29:02 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review updates
>
> test/jdk/javax/swing/text/html/HTMLDocument/bug4209280.java line 36:
> 
>> 34:     public static void main(String[] args) throws Exception {
>> 35:         String html = "<html><bold>Foo</bold></html>";
>> 36:         new JLabel(html);
> 
> Suggestion:
> 
>         // The following line should throw no exceptions
>         new JLabel(html);
> 
> This may clarify the intention of the reader skipped the summary.

Agreed. Adds more clarity. Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15769#discussion_r1330437794


More information about the client-libs-dev mailing list