RFR: 8315584 : java/awt/print/Dialog/DialogType.java fails with option not supported: yesno [v2]
Phil Race
prr at openjdk.org
Tue Sep 19 21:53:41 UTC 2023
On Wed, 6 Sep 2023 01:00:17 GMT, lawrence.andrews <duke at openjdk.org> wrote:
>> Test was failing with "test result: Error. Parse Exception: Arguments to `manual' option not supported: yesno"
>> Following are fixed
>> 1) Removed yesno
>> 2) Used PassFailJFrame manual test framework to show the test instruction & allow the user to decide test execution result.
>> 3) Added SkippedException in case Printer is not configured on the test host.
>> 4) Updated the instruction how to close the print dialog that test is showing to the user.
>> 5) Added an extra line to the file that was missing.
>
> lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:
>
> Removed the unused import statement and comma
test/jdk/java/awt/print/Dialog/DialogType.java line 52:
> 50: The test passes as long as no exceptions are thrown, *AND*,
> 51: if running on Windows only, the first dialog is a native windows
> 52: control which differs in appearance from the second dialog.
The above comment is out of date. It is from before we had macOS which also has a native dialog.
Please update it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15554#discussion_r1330742441
More information about the client-libs-dev
mailing list