RFR: 8316146: Open some swing tests 4
Alexey Ivanov
aivanov at openjdk.org
Fri Sep 22 12:42:16 UTC 2023
On Thu, 21 Sep 2023 22:36:16 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> Opening closed tests:
>> 12 javax/swing/ToolTipManager/5078214/bug5078214.java
>> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java
>> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java
>> 15 javax/swing/plaf/metal/4306431/bug4306431.java
>
> test/jdk/javax/swing/ToolTipManager/bug5078214.java line 102:
>
>> 100: System.out.print("We need at least one screen with ");
>> 101: System.out.println("the taskbar at the bottom position.");
>> 102: System.out.println("Testing skipped.");
>
> @azvegint mentioned about Ubuntu issue, you will probably need either a return or jtreg Skipped Exception here. Using jtreg Skipped Exception is more appropriate here.
I would also recommend inverting the condition to avoid additional indentation.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15875#discussion_r1334325660
More information about the client-libs-dev
mailing list