RFR: 8316146: Open some swing tests 4 [v3]

Alexey Ivanov aivanov at openjdk.org
Thu Sep 28 15:56:43 UTC 2023


On Fri, 22 Sep 2023 12:39:04 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/javax/swing/ToolTipManager/bug5078214.java line 102:
>> 
>>> 100:                     System.out.print("We need at least one screen with ");
>>> 101:                     System.out.println("the taskbar at the bottom position.");
>>> 102:                     System.out.println("Testing skipped.");
>> 
>> @azvegint mentioned about Ubuntu issue, you will probably need either a return or jtreg Skipped Exception here. Using jtreg Skipped Exception is more appropriate here.
>
> I would also recommend inverting the condition to avoid additional indentation.

This is still not resolved! You should throw `jtreg.SkippedException` if `getGraphicsConfig()` returns `null`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15875#discussion_r1337324056


More information about the client-libs-dev mailing list