RFR: 8316146: Open some swing tests 4 [v2]

Alexey Ivanov aivanov at openjdk.org
Mon Sep 25 11:48:17 UTC 2023


On Sun, 24 Sep 2023 06:12:17 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Opening closed tests:
>> 12 javax/swing/ToolTipManager/5078214/bug5078214.java
>> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java
>> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java
>> 15 javax/swing/plaf/metal/4306431/bug4306431.java
>
> Alisen Chung has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - updated tests based on feedback
>  - updated tests

test/jdk/javax/swing/BasicMenuItemUI/bug4239714.java line 27:

> 25:  * @test
> 26:  * @bug 4239714
> 27:  * @summary Tests that BasicMenuItemUI.installComponent() is protected

I doubt this test is useful… Wouldn't it be verified with JCK?

I had a similar doubt about another case where test used a new method that was added in 1.3.0 or an earlier release.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15875#discussion_r1335770533


More information about the client-libs-dev mailing list