RFR: 8316146: Open some swing tests 4 [v2]
Alisen Chung
achung at openjdk.org
Thu Sep 28 15:42:36 UTC 2023
On Mon, 25 Sep 2023 11:45:24 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Alisen Chung has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - updated tests based on feedback
>> - updated tests
>
> test/jdk/javax/swing/BasicMenuItemUI/bug4239714.java line 27:
>
>> 25: * @test
>> 26: * @bug 4239714
>> 27: * @summary Tests that BasicMenuItemUI.installComponent() is protected
>
> I doubt this test is useful… Wouldn't it be verified with JCK?
>
> I had a similar doubt about another case where test used a new method that was added in 1.3.0 or an earlier release.
Since this isn't a test for applet I think we should keep it for now
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15875#discussion_r1340346014
More information about the client-libs-dev
mailing list