RFR: JDK-8328753 : Open source few Undecorated Frame tests [v3]

Alexey Ivanov aivanov at openjdk.org
Tue Apr 2 17:14:10 UTC 2024


On Fri, 29 Mar 2024 17:29:09 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following tests are converted to main and open-sourced:
>> 
>> - /java/awt/Frame/FrameDialogMixedTest.java- Converted to main/manual using PassFailJFrame.
>> - /java/awt/Frame/MaximizeUndecoratedTest.java - Automated
>> - /java/awt/Frame/MinimizeUndecoratedTest.java - Automated
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   RuntimeException thrown

test/jdk/java/awt/Frame/MinimizeUndecoratedTest.java line 98:

> 96:             } else {
> 97:                 throw new RuntimeException("Window iconified event not received.");
> 98:             }

I'd invert the condition of the `if (!isMinimized())`, then everything inside the body of the `if`-block can be unindented.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18523#discussion_r1548267940


More information about the client-libs-dev mailing list