RFR: JDK-8328753 : Open source few Undecorated Frame tests [v3]

Harshitha Onkar honkar at openjdk.org
Tue Apr 2 18:02:30 UTC 2024


On Tue, 2 Apr 2024 17:11:04 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   RuntimeException thrown
>
> test/jdk/java/awt/Frame/MinimizeUndecoratedTest.java line 98:
> 
>> 96:             } else {
>> 97:                 throw new RuntimeException("Window iconified event not received.");
>> 98:             }
> 
> I'd invert the condition of the `if (!isMinimized())`, then everything inside the body of the `if`-block can be unindented.

Agreed. Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18523#discussion_r1548327779


More information about the client-libs-dev mailing list