RFR: 8328482: Convert and Open source few manual applet test to main based [v5]
Harshitha Onkar
honkar at openjdk.org
Wed Apr 3 00:27:10 UTC 2024
On Tue, 2 Apr 2024 04:42:12 GMT, Tejesh R <tr at openjdk.org> wrote:
>> test/jdk/java/awt/Frame/MegaIconTest/MegaIconTest.java line 194:
>>
>>> 192: setLayout(new BorderLayout());
>>> 193:
>>> 194: //Add the icon graphic and instructions to the Frame
>>
>> The background transparency of different gifs can be checked by setting the background of the Frame to a different color. For instance `setBackground(Color.YELLOW)` here and in the original test.
>>
>> Adding a different background color instead of white makes it easier for the tester to compare the different types of icon.
>
> Good suggestion about setting different background Color, but here since the classes extended from one another, it would be difficult to set different background Color for each icon.
I meant setting it to one color for all icons instead of default white background at Line#.193. This makes it easier for the user to differentiate between a transparent background icon vs opaque.
You might have missed this comment as to why I suggested the above -
> Does the test mean "icon with opaque background" by "opaque icon"? If yes, then we should use one .gif with opaque background and another with transparent background. Currently both gif files - dukeWave.gif and fight.gif, have transparent backgrounds.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1548763714
More information about the client-libs-dev
mailing list