RFR: 8328482: Convert and Open source few manual applet test to main based [v5]
Tejesh R
tr at openjdk.org
Wed Apr 3 16:19:24 UTC 2024
On Wed, 3 Apr 2024 00:18:24 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> Good suggestion about setting different background Color, but here since the classes extended from one another, it would be difficult to set different background Color for each icon.
>
> I meant setting it to one color for all icons instead of default white background at Line#.193. This makes it easier for the user to differentiate between a transparent background icon vs opaque.
>
> You might have missed this comment as to why I suggested the above -
>
>> Does the test mean "icon with opaque background" by "opaque icon"? If yes, then we should use one .gif with opaque background and another with transparent background. Currently both gif files - dukeWave.gif and fight.gif, have transparent backgrounds.
Yeah, had missed this point. Updated now, thanks for pointing it out.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1550054450
More information about the client-libs-dev
mailing list