RFR: 8328977 : JEditorPane.setPage not thread-safe, pageLoader not cancelled [v3]

[Tejesh R]

On Fri, 19 Apr 2024 14:53:09 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Added pageloader cancel before new page creation along with code restructuring. Moved all page loading calls inside synchronize to make it thread safe.
>> 
>> Regards,
>> Renjith.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Rearranged if based on suggesion

src/java.desktop/share/classes/javax/swing/JEditorPane.java line 483:

> 481:             // The same page with different reference
> 482:             if (reference != null) {
> 483:                 scrollToReference(reference);

Do we need to move ` scrollToReference(reference);` to swingUtil ? If not any reason for invoking it in swingUtil at line 547 and not here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18670#discussion_r1574244776