RFR: 8328977 : JEditorPane.setPage not thread-safe, pageLoader not cancelled [v3]

Tejesh R tr at openjdk.org
Mon Apr 22 08:43:33 UTC 2024


On Mon, 22 Apr 2024 07:19:04 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rearranged if based on suggesion
>
> src/java.desktop/share/classes/javax/swing/JEditorPane.java line 483:
> 
>> 481:             // The same page with different reference
>> 482:             if (reference != null) {
>> 483:                 scrollToReference(reference);
> 
> Do we need to move ` scrollToReference(reference);` to swingUtil ? If not any reason for invoking it in swingUtil at line 547 and not here?

Is it because of same page which is already loaded and no reloading is required?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18670#discussion_r1574365849


More information about the client-libs-dev mailing list