RFR: 8322135: javax/swing/JTable/JTableScrollPrintTest.java & javax/swing/JTable/PrintAllPagesTest.java throws java.lang.InternalError: HTHEME is null [v2]
Alexey Ivanov
aivanov at openjdk.org
Tue Apr 23 10:34:32 UTC 2024
On Tue, 23 Apr 2024 10:23:33 GMT, Tejesh R <tr at openjdk.org> wrote:
>> I didn't get the need for helper method?
>
> Ok, I got it. And I have updated. But if we want to change `theme` to `long`, then I guess we have to do it every calling function I guess. So is it better to leave it as `Long` ?
I still think we should change `Long` to `long`. Yes, you'll need to update it in the two methods. In `getThemeImpl`, it will be boxed into `Long` automatically before being put into the map.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18706#discussion_r1576027262
More information about the client-libs-dev
mailing list