RFR: 8322135: javax/swing/JTable/JTableScrollPrintTest.java & javax/swing/JTable/PrintAllPagesTest.java throws java.lang.InternalError: HTHEME is null [v2]

Alexey Ivanov aivanov at openjdk.org
Tue Apr 23 10:34:32 UTC 2024


On Tue, 23 Apr 2024 10:31:02 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Ok, I got it. And I have updated. But if we want to change `theme` to `long`, then I guess we have to do it every calling function I guess. So is it better to leave it as `Long` ?
>
> I still think we should change `Long` to `long`. Yes, you'll need to update it in the two methods. In `getThemeImpl`, it will be boxed into `Long` automatically before being put into the map.

When the primitive type `long` is used, there's no confusion whether the value can be `null` or not.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18706#discussion_r1576028406


More information about the client-libs-dev mailing list