RFR: 8233068: HIDPI: Linux: AWT Checkbox check mark is unscaled [v3]
Abhishek Kumar
abhiscxk at openjdk.org
Tue Aug 6 07:59:34 UTC 2024
On Mon, 5 Aug 2024 12:28:09 GMT, Tejesh R <tr at openjdk.org> wrote:
>> The check mark had been transformed with default scale which is 1.0 and the same is used on click of checkbox. This was done while computing the layout and not updated while paint. Hence the scaling update is done on painting the check mark and CI testing is green after the update too.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove image writing
test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java line 53:
> 51: Robot robot = new Robot();
> 52: try {
> 53: SwingUtilities.invokeAndWait(() -> {
I think `EventQueue.invokeAndWait()` should be used instead of `SwingUtilities.invokeAndWait()` for AWT test.
test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java line 54:
> 52: try {
> 53: SwingUtilities.invokeAndWait(() -> {
> 54: frame = new Frame("ComboBox checker scaling test");
Is it possible to render the checkbox into the buffered image directly and then do the testing?
This way, you can avoid creating the frame, adding component to it, using robot for screen capture.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20441#discussion_r1705077572
PR Review Comment: https://git.openjdk.org/jdk/pull/20441#discussion_r1705082559
More information about the client-libs-dev
mailing list