RFR: 8233068: HIDPI: Linux: AWT Checkbox check mark is unscaled [v3]

Tejesh R tr at openjdk.org
Tue Aug 6 11:04:34 UTC 2024


On Tue, 6 Aug 2024 07:52:49 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove image writing
>
> test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java line 53:
> 
>> 51:         Robot robot = new Robot();
>> 52:         try {
>> 53:             SwingUtilities.invokeAndWait(() -> {
> 
> I think `EventQueue.invokeAndWait()` should be used instead of `SwingUtilities.invokeAndWait()` for AWT test.

Why?

> test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java line 54:
> 
>> 52:         try {
>> 53:             SwingUtilities.invokeAndWait(() -> {
>> 54:                 frame = new Frame("ComboBox checker scaling test");
> 
> Is it possible to render the checkbox into the buffered image directly and then do the testing?
> 
> This way, you can avoid creating the frame, adding component to it, using robot for screen capture.

I guess it can be done, anyhow will try it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20441#discussion_r1705338940
PR Review Comment: https://git.openjdk.org/jdk/pull/20441#discussion_r1705339386


More information about the client-libs-dev mailing list