RFR: 4795384: GTK+ JFileChooser buttons should have mnemonics [v2]

Alisen Chung achung at openjdk.org
Tue Aug 20 23:54:04 UTC 2024


On Mon, 19 Aug 2024 07:32:26 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> JFileChooser don't have the mnemonics for open and save button in GTK L&F. Fix is to add mnemonics for open and save button.
>> Fix can be verified by Swingset2 demo application. Mnemonics in GTK L&F are visible once alt key is pressed.
>> After running the SwingSet2 application, change the `L&F to GTK` and select` JFileChooser demo` from toolbar. Click on `Select Plain JFileChooser` button and then press alt key to verify the mnemonics.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add mnemonics for Save and change Selection mnemonics

src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk.properties line 67:

> 65: FileChooser.saveDialogTitle.textAndMnemonic=Save
> 66: FileChooser.openDialogTitle.textAndMnemonic=Open
> 67: FileChooser.pathLabel.textAndMnemonic=S&election:

is this a typo? why is the S moved before the &?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20612#discussion_r1724108666


More information about the client-libs-dev mailing list