RFR: 4795384: GTK+ JFileChooser buttons should have mnemonics [v2]

Abhishek Kumar abhiscxk at openjdk.org
Wed Aug 21 03:53:06 UTC 2024


On Tue, 20 Aug 2024 23:51:08 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add mnemonics for Save and change Selection mnemonics
>
> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk.properties line 67:
> 
>> 65: FileChooser.saveDialogTitle.textAndMnemonic=Save
>> 66: FileChooser.openDialogTitle.textAndMnemonic=Open
>> 67: FileChooser.pathLabel.textAndMnemonic=S&election:
> 
> is this a typo? why is the S moved before the &?

No, that's not a typo. Proposed fix is to have mnemonic &S for save &e for Selection. 
Refer https://github.com/openjdk/jdk/pull/20612#discussion_r1720283148

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20612#discussion_r1724336908


More information about the client-libs-dev mailing list