RFR: 8338041: Keyboard Navigation of JTable, Ctrl Shift RIGHT/LEFT doesn't follow native action in GTK L&F [v2]
Harshitha Onkar
honkar at openjdk.org
Thu Aug 22 00:20:08 UTC 2024
On Tue, 20 Aug 2024 07:26:12 GMT, Tejesh R <tr at openjdk.org> wrote:
>> In JTable, keyboard navigation keys Ctrl Shift RIGHT/LEFT doesn't follow native actions of Linux. In native the actions are extended to end of selected columns cells either LEFT/RIGHT but in swing gtk look and feel the selection is extended to one cell to left/right. This might be taken as reference of Windows OS since the same is observed in Windows native. Hence I have update the actions for Ctrl Shift RIGHT & LEFT.
>> Added automated test too. The fix is tested in CI and its fine.
>
> Tejesh R has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Updated review comments
> - Merge branch 'master' of https://git.openjdk.java.net/jdk into branch_8338041
> - Test updates
> - Key action modified + Automatic test added
Fix looks good and works similar to native app - Libre Calc on linux.
-------------
PR Review: https://git.openjdk.org/jdk/pull/20608#pullrequestreview-2252454523
More information about the client-libs-dev
mailing list